Hi Rob, On Wed, 19 Feb 2025 16:35:30 -0600 Rob Herring <robh@xxxxxxxxxx> wrote: > On Thu, Feb 13, 2025 at 11:16:03AM +0100, Maxime Chevallier wrote: > > The ability to describe the physical ports of Ethernet devices is useful > > to describe multi-port devices, as well as to remove any ambiguity with > > regard to the nature of the port. > > > > Moreover, describing ports allows for a better description of features > > that are tied to connectors, such as PoE through the PSE-PD devices. > > > > Introduce a binding to allow describing the ports, for now with 2 > > attributes : > > > > - The number of lanes, which is a quite generic property that allows > > differentating between multiple similar technologies such as BaseT1 > > and "regular" BaseT (which usually means BaseT4). > > > > - The media that can be used on that port, such as BaseT for Twisted > > Copper, BaseC for coax copper, BaseS/L for Fiber, BaseK for backplane > > ethernet, etc. This allows defining the nature of the port, and > > therefore avoids the need for vendor-specific properties such as > > "micrel,fiber-mode" or "ti,fiber-mode". > > > > The port description lives in its own file, as it is intended in the > > future to allow describing the ports for phy-less devices. > > > > Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx> > > --- > > V4: no changes > > > > .../devicetree/bindings/net/ethernet-phy.yaml | 18 +++++++ > > .../bindings/net/ethernet-port.yaml | 47 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 3 files changed, 66 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/ethernet-port.yaml > > Seems my comments on v2 were ignored. Those issues remain. My bad, I apparently completely missed it :/ Let me get back to that :) Thanks, Maxime
