On Wed, Feb 19, 2025 at 11:49:21AM -0800, Jessica Zhang wrote: > From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> > > There is no recovery mechanism in place yet to recover from mmu > faults for DPU. We can only prevent the faults by making sure there > is no misconfiguration. > > Rate-limit the snapshot capture for mmu faults to once per > msm_atomic_commit_tail() as that should be sufficient to capture > the snapshot for debugging otherwise there will be a lot of DPU > snapshots getting captured for the same fault which is redundant > and also might affect capturing even one snapshot accurately. > > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> > Signed-off-by: Jessica Zhang <quic_jesszhan@xxxxxxxxxxx> > --- > Changes in v3: > - Clear fault_snapshot_capture before calling prepare_commit() (Dmitry) > - Make fault_snapshot_capture an atomic variable (Dmitry, Abhinav) > --- > drivers/gpu/drm/msm/msm_atomic.c | 2 ++ > drivers/gpu/drm/msm/msm_kms.c | 5 ++++- > drivers/gpu/drm/msm/msm_kms.h | 3 +++ > 3 files changed, 9 insertions(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
