On 2025/2/12 16:35, Krzysztof Kozlowski wrote:
On 12/02/2025 08:12, Yongxing Mou wrote:
We need to enable mst for qcs8300, dp0 controller will support 2 streams
output. So not reuse sm8650 dp controller driver and will add a new driver
patch for qcs8300 mst feature. Modify the corresponding dt-bingding file
to compatible with the qcs8300-dp.
Signed-off-by: Yongxing Mou <quic_yongmou@xxxxxxxxxxx>
NAK. You just said qcs8300 is compatible with sm8650. I did not ask
about drivers, I asked about hardware.
This is messy approach. Describe properly the hardware first, instead of
sending two conflicting patchsets.
Best regards,
Krzysztof
Hi, Krzysztof, thanks for reviewing, i want to explain why i submitted
this patch. Patch
https://lore.kernel.org/all/20250114-dts_qcs8300-v3-1-d114cc5e4af9@xxxxxxxxxxx/
and
https://lore.kernel.org/all/20250120-mdssdt_qcs8300-v4-2-1687e7842125@xxxxxxxxxxx/
is the qcs8300 display enablement changes. It base on current linux base
code and it only support SST mode, so in the SST mode, qcs8300 dp
controller driver is quite same with sm8650, struct msm_dp_desc only
have 3 members(io_start, id and wide_bus_supported) and they are same
both in qcs8300 and sm8650, so we reuse it. BTW, for dp phy hardware
version, qcs8300 and sm8650 is different.
For this patch series,
https://lore.kernel.org/all/20250212-mst_qcs8300-v1-0-38a8aa08394b@xxxxxxxxxxx/
, it is made on top of
https://lore.kernel.org/all/20241205-dp_mst-v1-0-f8618d42a99a@xxxxxxxxxxx/
which is a new feature for msm platform and not fully reviewed all the
code. Currently patch series enable the MST feature for qcs8300, so the
dp controller need to support stream 1, and we need add max_streams and
intf_map in the struct msm_dp_desc to support MST. So we don't reuse the
sm8650 drivers in this patch series.
For my understanding, qcs8300 SST changes should merge
first(https://lore.kernel.org/all/20250114-dts_qcs8300-v3-0-d114cc5e4af9@xxxxxxxxxxx/
and
https://lore.kernel.org/all/20250120-mdssdt_qcs8300-v4-0-1687e7842125@xxxxxxxxxxx/),
and next is the MST base commits
(https://lore.kernel.org/all/20241205-dp_mst-v1-0-f8618d42a99a@xxxxxxxxxxx/),
and this patch series should merge at last. why i post qcs8300
enablement changes first and then post the MST changes instead of post
them together? Because our dependency, i mean this patch series
(https://lore.kernel.org/all/20241205-dp_mst-v1-0-f8618d42a99a@xxxxxxxxxxx/),
it has about 45 changes, so it might take lots of time to merge. we just
want to make sure that display can work on DP SST mode first.
So I am just understand that the previous commit was not an incorrect
commit, but rather two functionalities were changed in the same place.
Thanks,
Yongxing
