I wanted to check in on this. Anything I need to change? Thanks, Ethan On 25/01/19 08:32PM, Ethan Carter Edwards wrote: > We are replacing any instances of kzalloc(size * count, ...) with > kcalloc(count, size, ...) due to risk of overflow [1]. > > [1] https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments > Link: https://github.com/KSPP/linux/issues/162 > > Signed-off-by: Ethan Carter Edwards <ethan@xxxxxxxxxxxxxxxxx> > --- > sound/soc/qcom/qdsp6/q6apm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c > index 2a2a5bd98110..11e252a70f69 100644 > --- a/sound/soc/qcom/qdsp6/q6apm.c > +++ b/sound/soc/qcom/qdsp6/q6apm.c > @@ -230,7 +230,7 @@ int q6apm_map_memory_regions(struct q6apm_graph *graph, unsigned int dir, phys_a > return 0; > } > > - buf = kzalloc(((sizeof(struct audio_buffer)) * periods), GFP_KERNEL); > + buf = kcalloc(periods, sizeof(struct audio_buffer), GFP_KERNEL); > if (!buf) { > mutex_unlock(&graph->lock); > return -ENOMEM; > -- > 2.48.0 >
