On Sat, Feb 08, 2025 at 04:00:15PM +0800, Chukun Pan wrote: > Hi, > > Wouldn't it be better to move it to the board file without having > > intermediate include files? > > The intermediate include files were suggested by you: > https://lore.kernel.org/lkml/xmvtbib3q72tnfpcaic3vbgwilpo7yjnqimr5uk2myjgtslbgm@mlp2kqvljayc/ > > Unlike mobile phones or development boards, the pmic (voltage) setting > on routers is relatively fixed. (Because QCA will not provide relevant > documents). On IPQ60xx SoCs, s2 supplies to cpu, l2 supplies to emmc. > The downstream vendor kernel puts it in soc.dtsi (no device override), > so I think the include files is more appropriate. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
