On Wed, Aug 17, 2016 at 11:40 PM, Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote: >> + led@48 { >> + /* >> + * The keypad LED @0x48 is routed >> to >> + * the sensor board where it is >> + * connected to an infrared LED >> + * SFH4650 (60mW, @850nm) next to >> the >> + * ambient light and proximity >> sensor >> + * Capella Microsystems CM3605. >> + */ >> + compatible = >> "qcom,pm8058-keypad-led"; >> + reg = <0x48>; >> + label = "proximity0"; > > > In DT bindings documentation it was changed to "pm8050:white:keypad" to > adhere to the LED class device naming convention. I assume that having > it in this form is an omission here. Hm right. Given the usecase here, what do you say about naming it: "pm8058:infrared:proximitysensor" ? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html