Re: [PATCH RESEND v2 0/3] arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/14/2025 10:46 PM, Ricky Cheung wrote:
Good evening.

This patch adds support for the XiaoXun JZ0145 v33 4G LTE WiFi modem
based on the MSM8916 chipset by a new manufacturer / vendor for the
Linux Kernel called called XiaoXun BiCheng Technology. Below is some
information about these changes.

I'm glad to see another msm8916-ufi.dtsi user in mainline. But this patchset still contains some errors and needs to be fixed before getting applied.


Addition of a new vendor prefix
----------

XiaoXun BiCheng Technology is not well known in that they don't seem
to have a presence in the Western world. I purchased my own modem
on TaoBao, which requires stores to registered as businesses, so
I believe it is justified to add it as a vendor prefix. Note that the
company appears to have shut down just this month.

Be sure to know the real manufacturer rather than a random store. For example, we know most Xiaomi phones are actually manufactured and designed by Wingtech(闻泰) rather Xiaomi, so the dts for them are wingtech-msm8916-xxxx etc.. The same logic applies to the UFI dongles too. Try to get the box of your dongle and see if you can find the real vendor design the board rather than the company who just sells them.


Status of patch
----------

This device shares many similarities to pre-existing devices within
arch/arm64/boot/dts/msm8916-ufi.dtsi, so I am sure most features would
function with the correct firmware on this device.

However, due to the poor quality of these devices, my unit's EMMC has
failed and I cannot conduct further tests. Previous, the modem was
able to boot with devicetree of a UZ801, albeit with LED and Modem
issues, which is addressed in this patch.

I have sent the code for testing to some kind folks on the Internet with
good outcomes, so do consider this code as ready and functional.

This patch was also reviewed over at the msm8916-mainline organization
and deemed ready by the maintainer:

	https://github.com/msm8916-mainline/linux/pull/386

Note that this is my first patch to the LKML, so if there's something I
did wrong / the patch is missing, please point it out.

Best Regards,
Ricky Cheung
Tipz Team

Signed-off-by: Ricky Cheung <rcheung844@xxxxxxxxx>
---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/20250114-xiaoxun-jz0145-v33-v1-0-dc51f7ce3bd8@xxxxxxxxx

---
Ricky Cheung (3):
       dt-bindings: vendor-prefixes: Add XiaoXun BiCheng Technology
       dt-bindings: arm: qcom: Add XiaoXun JZ0145 v33
       arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree

  Documentation/devicetree/bindings/arm/qcom.yaml    |  1 +
  .../devicetree/bindings/vendor-prefixes.yaml       |  2 +
  arch/arm64/boot/dts/qcom/Makefile                  |  1 +
  .../boot/dts/qcom/msm8916-xiaoxun-jz0145-v33.dts   | 66 ++++++++++++++++++++++
  4 files changed, 70 insertions(+)
---
base-commit: d390303b28dabbb91b2d32016a4f72da478733b9
change-id: 20250114-xiaoxun-jz0145-v33-23dc006cf130

Best regards,

--
Regards,
Yang Xiwen





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux