Re: [PATCH v3 7/8] scsi: ufs: core: Toggle Write Booster during clock scaling base on gear speed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>, quic_cang@xxxxxxxxxxx, bvanassche@xxxxxxx, mani@xxxxxxxxxx, beanhuo@xxxxxxxxxx, avri.altman@xxxxxxx, junwoo80.lee@xxxxxxxxxxx, martin.petersen@xxxxxxxxxx, quic_nguyenb@xxxxxxxxxxx, quic_nitirawa@xxxxxxxxxxx, quic_rampraka@xxxxxxxxxxx
Subject: Re: [PATCH v3 7/8] scsi: ufs: core: Toggle Write Booster during clock scaling base on gear speed
From: Bean Huo <huobean@xxxxxxxxx>
Date: Wed, 05 Feb 2025 21:03:06 +0100
Cc: linux-arm-msm@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Peter Wang <peter.wang@xxxxxxxxxxxx>, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>, Andrew Halaney <ahalaney@xxxxxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, Minwoo Im <minwoo.im@xxxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20250203081109.1614395-8-quic_ziqichen@quicinc.com>
References: <20250203081109.1614395-1-quic_ziqichen@quicinc.com> <20250203081109.1614395-8-quic_ziqichen@quicinc.com>
User-agent: Evolution 3.44.4-0ubuntu2

On Mon, 2025-02-03 at 16:11 +0800, Ziqi Chen wrote:
> > +       if (!hba->clk_scaling.wb_gear)
> > +               hba->clk_scaling.wb_gear = UFS_HS_G3;
> > +

Hi Ziqi, 

Initializes wb_gear to UFS_HS_G3, mabye add comments in the commit why.


Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>

Follow-Ups:
- Re: [PATCH v3 7/8] scsi: ufs: core: Toggle Write Booster during clock scaling base on gear speed
  - From: Ziqi Chen

References:
- [PATCH v3 0/8] Support Multi-frequency scale for UFS
  - From: Ziqi Chen
- [PATCH v3 7/8] scsi: ufs: core: Toggle Write Booster during clock scaling base on gear speed
  - From: Ziqi Chen

Prev by Date: Re: [PATCH v3 5/8] scsi: ufs: core: Enable multi-level gear scaling
Next by Date: Re: (subset) [PATCH v1 0/2] Fix USB vdd info for IPQ9574
Previous by thread: Re: [PATCH v3 7/8] scsi: ufs: core: Toggle Write Booster during clock scaling base on gear speed
Next by thread: Re: [PATCH v3 7/8] scsi: ufs: core: Toggle Write Booster during clock scaling base on gear speed
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]