On 30/01/2025 12:29, Alexey Minnekhanov wrote:
> On 1/30/25 11:35 AM, Krzysztof Kozlowski wrote:
>> On Thu, Jan 30, 2025 at 12:23:25AM +0300, Alexey Minnekhanov wrote:
>>> Add resets for eMMC/SD card blocks that were missed during initial
>>> driver submission.
>>>
>>> Signed-off-by: Alexey Minnekhanov <alexeymin@xxxxxxxxxxxxxxxx>
>>> Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660")
>>
>> Your SoB is always the last tag, but repeating what I asked during
>> previous review - what sort of bug is here? Missing feature is not a bug
>> per se.
>>
>> Best regards,
>> Krzysztof
>>
>
> I was hesitant about adding fixes tag myself, because there is no any
> user-observable bug being fixed here. In fact the behavior is unchanged,
> eMMC and SD worked fine before this and still work fine with this patch.
> From Linux side this is mostly for consistency with other
> younger/sibling SoCs, like MSM8998 & 8996 all have these resets
> specified. This will probably be much more useful for U-Boot port.
>
> Perhaps fixes tag should be removed completely?
Yes, drop the Fixes tag.
Best regards,
Krzysztof
