On 21/01/2025 17:02, Vikram Sharma wrote: > > On 1/21/2025 6:25 PM, Krzysztof Kozlowski wrote: >> On 21/01/2025 13:09, Vikram Sharma wrote: >>> This patch change clock names to make it consistent with >> >> Please do not use "This commit/patch/change", but imperative mood. See >> longer explanation here: >> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > Hi Krzysztof, > Thanks for your response. > Will update commit text. >>> existing platforms as gcc_cam_hf_axi -> gcc_axi_hf. >> Which ones? sm8250 uses different. > qcom,sc8280xp-camss.yaml uses 'gcc_axi_hf' Then mention with which binding you align it. >> >>> This also adds gcc_axi_sf and remove gcc_camera_ahb. >> Why? > > 'gcc_camera_ahb' is always 'on' and we don't need to enable it explicitly. > 'gcc_axi_sf' basic use case works even without this clock but our 'Hardware programing guide' suggest to enable this one too to avoid unexpected behaviors. > Konrad pointed these points in V8 of the series. That's what the commit msg is for. Best regards, Krzysztof
