Hi Raviteja, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Raviteja-Laggyshetty/interconnect-core-Add-dynamic-id-allocation-support/20250112-001756 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20250111161429.51-2-quic_rlaggysh%40quicinc.com patch subject: [PATCH V7 1/5] interconnect: core: Add dynamic id allocation support config: arm-randconfig-r072-20250118 (https://download.01.org/0day-ci/archive/20250120/202501201530.UTAPd4lC-lkp@xxxxxxxxx/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project c23f2417dc5f6dc371afb07af5627ec2a9d373a0) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202501201530.UTAPd4lC-lkp@xxxxxxxxx/ smatch warnings: drivers/interconnect/core.c:889 icc_node_create_alloc_id() warn: inconsistent returns 'global &icc_lock'. vim +889 drivers/interconnect/core.c 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 867 struct icc_node *icc_node_create_alloc_id(int start_id) 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 868 { 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 869 struct icc_node *node; 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 870 int id; 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 871 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 872 mutex_lock(&icc_lock); 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 873 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 874 node = kzalloc(sizeof(*node), GFP_KERNEL); Do this allocation before taking the mutex_lock(&icc_lock). Otherwise you'd have to unlock before returning. 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 875 if (!node) 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 876 return ERR_PTR(-ENOMEM); 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 877 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 878 id = idr_alloc(&icc_idr, node, start_id, 0, GFP_KERNEL); 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 879 if (id < 0) { 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 880 WARN(1, "%s: couldn't get idr\n", __func__); 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 881 kfree(node); 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 882 node = ERR_PTR(id); 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 883 goto out; 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 884 } 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 885 node->id = id; 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 886 out: 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 887 mutex_unlock(&icc_lock); 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 888 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 @889 return node; 65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 890 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
