On Thu, Jan 16, 2025 at 10:22:07PM +0800, Jun Nie wrote: > Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> 于2025年1月16日周四 16:18写道: > > > > On Thu, Jan 16, 2025 at 03:26:03PM +0800, Jun Nie wrote: > > > Support SSPP assignment for quad-pipe case with unified method. > > > The first 2 pipes can share a set of mixer config and enable > > > multi-rect mode if condition is met. It is also the case for > > > the later 2 pipes. > > > > Missing problem description. > > Is this OK? > SSPP are assigned for 2 pipes at most with current implementation, > while 4 pipes are required in quad-pipe usage case with involving > configuration of 2 stages. Assign SSPPs for pipes of a stage in a > loop with unified method. The first 2 pipes can shar a set of mixer > config and enable multi-rect mode if condition is met. It is also the > case for the later 2 pipes. No. It should be problem / analysys/ solution. So, 'Assign foo' should become a last phrase. Also please please perform a grammar / typos check. > > > > > Also, shouldn't this patch come before the previous one? > > > Yeah, it is reasonable to prepare the assignment capability, then > enable the plane splitting into 4 pipes. It does not hurt actually > because quad-pipe is not enabled in data structure side. > Will reverse the sequence in next version anyway. Thanks! -- With best wishes Dmitry