On Mon, Dec 23, 2024 at 5:09 AM Yuvaraj Ranganathan <quic_yrangana@xxxxxxxxxxx> wrote: > > Add the QCE and Crypto BAM DMA nodes. > > Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@xxxxxxxxxxx> > --- > Changes in v3: > - Wrap the lengthy lines > - Reduced the patch series as other patch is merged. > - Link to v2: https://lore.kernel.org/all/20241125111923.2218374-3-quic_yrangana@xxxxxxxxxxx/ > > Changes in v2: > - Set the interconnect tag to QCOM_ICC_TAG_ALWAYS instead of passing 0(no TAG). > - Link to v1: https://lore.kernel.org/all/20241113055830.2918347-1-quic_yrangana@xxxxxxxxxxx/ > > --- > arch/arm64/boot/dts/qcom/qcs8300.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi > index 73abf2ef9c9f..30c1de1c4ad2 100644 > --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi > @@ -736,6 +736,31 @@ ufs_mem_phy: phy@1d87000 { > status = "disabled"; > }; > > + cryptobam: dma-controller@1dc4000 { > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > + reg = <0x0 0x01dc4000 0x0 0x28000>; > + interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; > + #dma-cells = <1>; > + qcom,ee = <0>; > + qcom,controlled-remotely; > + num-channels = <20>; > + qcom,num-ees = <4>; > + iommus = <&apps_smmu 0x480 0x00>, > + <&apps_smmu 0x481 0x00>; > + }; > + > + crypto: crypto@1dfa000 { > + compatible = "qcom,qcs8300-qce", "qcom,qce"; This doesn't match what the schema says. You didn't test your schema change with this. That's the *whole* point of the schemas... Rob