On 25/12/2024 09:58, Yijie Yang wrote: > > > On 2024-12-24 17:02, Krzysztof Kozlowski wrote: >> On 24/12/2024 04:07, Yijie Yang wrote: >>> The core version of EMAC on qcs615 has minor differences compared to that >>> on sm8150. During the bring-up routine, the loopback bit needs to be set, >>> and the Power-On Reset (POR) status of the registers isn't entirely >>> consistent with sm8150 either. >>> Therefore, it should be treated as a separate entity rather than a >>> fallback option. >> >> ... and explanation of ABI impact? You were asked about this last time, >> so this is supposed to end up here. > > I actually replied to this query last time, but maybe it wasn't clear. > Firstly, no one is using Ethernet on this platform yet. Secondly, the > previous fallback to sm8150 is incorrect and causes packet loss. > Instead, it should fall back to qcs404. > And if you send v3 with same commit msg, I will ask the same. Your commit msg must answer to this. Best regards, Krzysztof
