Re: [PATCH v9 27/28] media: iris: enable video driver probe of SM8250 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>, Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx>
Subject: Re: [PATCH v9 27/28] media: iris: enable video driver probe of SM8250 SoC
From: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
Date: Mon, 23 Dec 2024 11:30:27 +0100
Cc: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx>, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, "Rob Herring" <robh@xxxxxxxxxx>, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, "Conor Dooley" <conor+dt@xxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Hans Verkuil <hverkuil@xxxxxxxxx>, "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>, Neil Armstrong <neil.armstrong@xxxxxxxxxx>, Nicolas Dufresne <nicolas@xxxxxxxxxxxx>, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>, Jianhua Lu <lujianhua000@xxxxxxxxx>, "Stefan Schmidt" <stefan.schmidt@xxxxxxxxxx>, <linux-media@xxxxxxxxxxxxxxx>, <linux-arm-msm@xxxxxxxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20241212-qcom-video-iris-v9-27-e8c2c6bd4041@quicinc.com>
References: <20241212-qcom-video-iris-v9-0-e8c2c6bd4041@quicinc.com> <20241212-qcom-video-iris-v9-27-e8c2c6bd4041@quicinc.com>

Em Thu, 12 Dec 2024 17:21:49 +0530
Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> escreveu:

> +	.dma_mask = GENMASK(31, 29) - 1,

Setting a mask to GENMASK() - 1 sounds weird. Is it really what you want?
I so, why?

Thanks,
Mauro

Follow-Ups:
- Re: [PATCH v9 27/28] media: iris: enable video driver probe of SM8250 SoC
  - From: Dikshita Agarwal

References:
- [PATCH v9 00/28] Qualcomm iris video decoder driver
  - From: Dikshita Agarwal
- [PATCH v9 27/28] media: iris: enable video driver probe of SM8250 SoC
  - From: Dikshita Agarwal

Prev by Date: Re: [PATCH v2 1/2] misc: fastrpc: Deregister device nodes properly in error scenarios
Next by Date: Re: [PATCH v2 1/2] misc: fastrpc: Deregister device nodes properly in error scenarios
Previous by thread: [PATCH v9 27/28] media: iris: enable video driver probe of SM8250 SoC
Next by thread: Re: [PATCH v9 27/28] media: iris: enable video driver probe of SM8250 SoC
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]