On 20.12.2024 11:21 AM, Luca Weiss wrote: > On Fri Dec 20, 2024 at 10:42 AM CET, Konrad Dybcio wrote: >> On 20.12.2024 10:03 AM, Luca Weiss wrote: >>> If a clk_rcg2 has a parent, it should also have parent_map defined, >> >> ^ >> freq_tbl > > I was basing this on that part of the clk-rcg2.c, so for every parent > there also needs to be a parent_map specified. > > int num_parents = clk_hw_get_num_parents(hw); > [...] > for (i = 0; i < num_parents; i++) > if (cfg == rcg->parent_map[i].cfg) > [...] > > Should I still change the commit message? I guess there's no clk_rcg2 > without a parent at all? > > I guess I could reword it like that also or something? > > A clk_rcg2 needs to have a parent_map entry for every parent it has, > otherwise [...] > > Regards > Luca Okay I suppose it's fine as-is Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> Konrad
