On Fri, Dec 20, 2024 at 11:48:53AM +0530, ANANDU KRISHNAN E wrote: > During fastrpc_rpmsg_probe, if secure device node registration > succeeds but non-secure device node registration fails, the secure > device node deregister is not called during error cleanup. Add proper > exit paths to ensure proper cleanup in case of error. > > Signed-off-by: ANANDU KRISHNAN E <quic_anane@xxxxxxxxxxx> Please fix your name in your Git setup. The patch misses Fixes: tag and also cc:stable. > --- > drivers/misc/fastrpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index 48d08eeb2d20..ff144f0aa337 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -2344,7 +2344,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) > > err = fastrpc_device_register(rdev, data, false, domains[domain_id]); > if (err) > - goto fdev_error; > + goto populate_error; > break; > default: > err = -EINVAL; > -- > 2.17.1 > -- With best wishes Dmitry