On 12/13/2024 6:29 PM, Konrad Dybcio wrote:
> On 25.11.2024 6:07 AM, Manikanta Mylavarapu wrote:
>> From: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
>>
>> IPQ5332 has tsens v2.3.3 peripheral. This patch adds the tsens
>> node with nvmem cells for calibration data.
>>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
>> ---
>
> [...]
>
>>
>> + tsens: thermal-sensor@4a9000 {
>> + compatible = "qcom,ipq5332-tsens";
>> + reg = <0x004a9000 0x1000>,
>> + <0x004a8000 0x1000>;
>> + nvmem-cells = <&tsens_mode>,
>> + <&tsens_base0>,
>> + <&tsens_base1>,
>> + <&tsens_sens11_off>,
>> + <&tsens_sens12_off>,
>> + <&tsens_sens13_off>,
>> + <&tsens_sens14_off>,
>> + <&tsens_sens15_off>;
>> + nvmem-cell-names = "mode",
>> + "base0",
>> + "base1",
>> + "tsens_sens11_off",
>> + "tsens_sens12_off",
>> + "tsens_sens13_off",
>> + "tsens_sens14_off",
>> + "tsens_sens15_off";
>> + interrupts = <GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "combined";
>
> Please move interrupts properties above nvmem
>
Sure, i will move in next version.
Thanks & Regards,
Manikanta.
> with that:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> Konrad
