On Fri, Dec 13, 2024 at 01:24:24PM +0100, Konrad Dybcio wrote: > On 13.12.2024 9:42 AM, Johan Hovold wrote: > > On Thu, Dec 12, 2024 at 05:32:24PM +0100, Konrad Dybcio wrote: > >> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> > >> > >> Do so in accordance with the internal recommendations. > > > > Your commit message is still incomplete as it does not really say > > anything about what this patch does, why this is needed or what the > > implications are if not merging this patch. > > I'm not sure I can say much more here.. If you don't know what this slice is used for or what impact enabling it has then saying so in the commit message is also useful information. But you should be able to provide some background for reviewers, stable maintainers, other devs, posterity, ... > > How would one determine that this patch is a valid candidate for > > backporting, for example. > > "suboptimal hw presets" I'm sure the patch is correct, but spell something out in the commit message. Johan
