On Thu, Dec 12, 2024 at 07:14:22PM +0100, Konrad Dybcio wrote: > On 11.12.2024 9:26 AM, Song Xue wrote: > > From: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx> > > > > Enable secondary USB controller on QCS615 Ride platform. The secondary > > USB controller is made "host", as it is a Type-A port. > > > > Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx> > > Co-developed-by: Song Xue <quic_songxue@xxxxxxxxxxx> > > Signed-off-by: Song Xue <quic_songxue@xxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/qcs615-ride.dts | 28 ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts > > index f41319ff47b983d771da52775fa78b4385c4e532..26ce0496d13ccbfea392c6d50d9edcab85fbc653 100644 > > --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts > > +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts > > @@ -203,6 +203,15 @@ &gcc { > > <&sleep_clk>; > > }; > > > > +&pm8150_gpios { > > + usb2_en_state: usb2-en-state { > > + pins = "gpio10"; > > + function = "normal"; > > + output-high; > > + power-source = <0>; > > + }; > > Does this go to an enable pin of a vreg / switch? > > I think we settled on describing such cases as fixed regulators > (that are always-on for now) - would you remember, +Dmitry? You are right. Usually it's a fixed regulator. At least there should be an explanation for that pin. > > The rest looks good. > > Konrad -- With best wishes Dmitry