On 10.12.2024 4:38 PM, Johan Hovold wrote: > On Tue, Dec 10, 2024 at 01:27:26PM +0000, Marc Zyngier wrote: >> On Tue, 10 Dec 2024 13:18:20 +0000, >> Johan Hovold <johan@xxxxxxxxxx> wrote: >>> >>> On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote: >>>> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 >>>> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 >>>> are actually powered by &vreg_l2j_1p2. >>>> >>>> Since most X1E device trees just mirror the power supplies from the >>>> x1e80100-crd device tree, this series fixes up all the X1E boards with >>>> the same change. >>> >>> Nice find! I've confirmed that this matches both the CRD and T14s >>> schematics. >> >> Can someone with access to the schematics confirm that the devkit >> indeed has the same supplies? > > Sibi, can you confirm our assumption that these definitions were copied > from the CRD devicetree and need to be fixed like this also for the > devkit? I can confirm the fix applies to devkit too. Konrad
