On Fri Nov 1, 2024 at 8:14 AM GMT, Krzysztof Kozlowski wrote: > On Fri, Nov 01, 2024 at 05:31:52AM +0000, Alexey Klimov wrote: > > One WSA881X amplifier is connected on QRB4210 RB2 board > > hence only mono speaker is supported. This amplifier is set > > to work in analog mode only. Also add required powerdown > > pins/gpios. > > > > Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > > Signed-off-by: Alexey Klimov <alexey.klimov@xxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 45 ++++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > index fc71f5930688..76b9ae1b0ebc 100644 > > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > @@ -63,6 +63,16 @@ hdmi_con: endpoint { [..] > > + wsa_en_sleep: wsa-en-sleep-state { > > + pins = "gpio106"; > > + function = "gpio"; > > + drive-strength = <2>; > > + bias-pull-down; > > + input-enable; > > Are you sure this passes dtbs_check? I think this was not allowed since > 1.5 years. I guess you were referring to thing that input-enable is not allowed and output-disable must be used instead introduced by: c4a48b0df8bf dt-bindings: pinctrl: qcom: tlmm should use output-disable, not input-enable Noted. This sleep state seems to be unused hence I will remove it. Also, I am going to use Konrad's suggestion about i2c gpio for now. Hope it is okay. Thanks, Alexey