Quoting Dmitry Baryshkov (2024-12-02 02:06:36) > diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/drm/msm/dp/dp_aux.c > index bc8d46abfc619d669dce339477d58fb0c464a3ea..46e8a2e13ac1d1249fbad9b50a6d64c52d51cf38 100644 > --- a/drivers/gpu/drm/msm/dp/dp_aux.c > +++ b/drivers/gpu/drm/msm/dp/dp_aux.c > @@ -45,6 +46,73 @@ struct msm_dp_aux_private { > struct drm_dp_aux msm_dp_aux; > }; > > +static int msm_dp_aux_clear_hw_interrupts(struct msm_dp_aux_private *aux) Can you make this return void as well? > +{ > + struct msm_dp_catalog *msm_dp_catalog = aux->catalog; > + > + msm_dp_read_aux(msm_dp_catalog, REG_DP_PHY_AUX_INTERRUPT_STATUS); > + msm_dp_write_aux(msm_dp_catalog, REG_DP_PHY_AUX_INTERRUPT_CLEAR, 0x1f); > + msm_dp_write_aux(msm_dp_catalog, REG_DP_PHY_AUX_INTERRUPT_CLEAR, 0x9f); > + msm_dp_write_aux(msm_dp_catalog, REG_DP_PHY_AUX_INTERRUPT_CLEAR, 0); > + > + return 0; > +}