On Wed, Dec 11, 2024 at 5:25 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > Minor cleanups without funcitonal impact: > - There should not be an empty blank line after SPDX tag, > - Convention is to indent DTS examples in coding style with 2- or > 4-space indentation (4 is preferred), > - Drop unused labels in DTS examples. > > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Resending second time, because I missed previous Rob's review. > > I added now also Bryan's and Heiko's reviews from last resend. > --- > .../media/allwinner,sun50i-h6-vpu-g2.yaml | 1 - FWIW, Acked-by: Chen-Yu Tsai <wens@xxxxxxxx> > .../bindings/media/amlogic,meson-ir-tx.yaml | 1 - > .../bindings/media/amphion,vpu.yaml | 1 - > .../bindings/media/fsl,imx6ull-pxp.yaml | 1 - > .../media/mediatek,vcodec-decoder.yaml | 1 - > .../media/mediatek,vcodec-encoder.yaml | 1 - > .../media/mediatek,vcodec-subdev-decoder.yaml | 1 - > .../media/microchip,sama5d4-vdec.yaml | 17 ++++---- > .../bindings/media/nxp,imx8mq-vpu.yaml | 41 +++++++++---------- > .../bindings/media/qcom,msm8916-camss.yaml | 1 - > .../bindings/media/qcom,msm8996-camss.yaml | 1 - > .../bindings/media/qcom,sdm660-camss.yaml | 1 - > .../bindings/media/qcom,sdm845-camss.yaml | 1 - > .../bindings/media/qcom,sm8250-camss.yaml | 1 - > .../bindings/media/rockchip,rk3568-vepu.yaml | 1 - > .../bindings/media/rockchip-vpu.yaml | 29 +++++++------ > 16 files changed, 42 insertions(+), 58 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun50i-h6-vpu-g2.yaml b/Documentation/devicetree/bindings/media/allwinner,sun50i-h6-vpu-g2.yaml > index a4f06bbdfe49..8ba5177ac631 100644 > --- a/Documentation/devicetree/bindings/media/allwinner,sun50i-h6-vpu-g2.yaml > +++ b/Documentation/devicetree/bindings/media/allwinner,sun50i-h6-vpu-g2.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/allwinner,sun50i-h6-vpu-g2.yaml# > diff --git a/Documentation/devicetree/bindings/media/amlogic,meson-ir-tx.yaml b/Documentation/devicetree/bindings/media/amlogic,meson-ir-tx.yaml > index 377acce93423..6da8a6aded23 100644 > --- a/Documentation/devicetree/bindings/media/amlogic,meson-ir-tx.yaml > +++ b/Documentation/devicetree/bindings/media/amlogic,meson-ir-tx.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/amlogic,meson-ir-tx.yaml# > diff --git a/Documentation/devicetree/bindings/media/amphion,vpu.yaml b/Documentation/devicetree/bindings/media/amphion,vpu.yaml > index 9801de3ed84e..5a920d9e78c7 100644 > --- a/Documentation/devicetree/bindings/media/amphion,vpu.yaml > +++ b/Documentation/devicetree/bindings/media/amphion,vpu.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/amphion,vpu.yaml# > diff --git a/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > index 84a5e894ace4..3f47744459aa 100644 > --- a/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > +++ b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/fsl,imx6ull-pxp.yaml# > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml > index b401c67e3ba0..d726d141a434 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/mediatek,vcodec-decoder.yaml# > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml > index b45743d0a9ec..110e8f5f1f9e 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/mediatek,vcodec-encoder.yaml# > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml > index a500a585c692..5865e6f0be89 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/mediatek,vcodec-subdev-decoder.yaml# > diff --git a/Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml b/Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml > index 59b805ca47c5..ede086d55add 100644 > --- a/Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml > +++ b/Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/microchip,sama5d4-vdec.yaml# > @@ -36,12 +35,12 @@ additionalProperties: false > > examples: > - | > - #include <dt-bindings/clock/at91.h> > - #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/clock/at91.h> > + #include <dt-bindings/interrupt-controller/irq.h> > > - vdec0: vdec@300000 { > - compatible = "microchip,sama5d4-vdec"; > - reg = <0x00300000 0x100000>; > - interrupts = <19 IRQ_TYPE_LEVEL_HIGH 4>; > - clocks = <&pmc PMC_TYPE_PERIPHERAL 19>; > - }; > + vdec@300000 { > + compatible = "microchip,sama5d4-vdec"; > + reg = <0x00300000 0x100000>; > + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 4>; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 19>; > + }; > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml > index 3d58f02b0c5d..19528262810a 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/nxp,imx8mq-vpu.yaml# > @@ -44,26 +43,26 @@ additionalProperties: false > > examples: > - | > - #include <dt-bindings/clock/imx8mq-clock.h> > - #include <dt-bindings/power/imx8mq-power.h> > - #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/imx8mq-clock.h> > + #include <dt-bindings/power/imx8mq-power.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > - vpu_g1: video-codec@38300000 { > - compatible = "nxp,imx8mq-vpu-g1"; > - reg = <0x38300000 0x10000>; > - interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clk IMX8MQ_CLK_VPU_G1_ROOT>; > - power-domains = <&vpu_blk_ctrl IMX8MQ_VPUBLK_PD_G1>; > - }; > + video-codec@38300000 { > + compatible = "nxp,imx8mq-vpu-g1"; > + reg = <0x38300000 0x10000>; > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk IMX8MQ_CLK_VPU_G1_ROOT>; > + power-domains = <&vpu_blk_ctrl IMX8MQ_VPUBLK_PD_G1>; > + }; > - | > - #include <dt-bindings/clock/imx8mq-clock.h> > - #include <dt-bindings/power/imx8mq-power.h> > - #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/imx8mq-clock.h> > + #include <dt-bindings/power/imx8mq-power.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > - vpu_g2: video-codec@38300000 { > - compatible = "nxp,imx8mq-vpu-g2"; > - reg = <0x38310000 0x10000>; > - interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clk IMX8MQ_CLK_VPU_G2_ROOT>; > - power-domains = <&vpu_blk_ctrl IMX8MQ_VPUBLK_PD_G2>; > - }; > + video-codec@38300000 { > + compatible = "nxp,imx8mq-vpu-g2"; > + reg = <0x38310000 0x10000>; > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk IMX8MQ_CLK_VPU_G2_ROOT>; > + power-domains = <&vpu_blk_ctrl IMX8MQ_VPUBLK_PD_G2>; > + }; > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml > index 9cc0a968a401..3469a43f00d4 100644 > --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/qcom,msm8916-camss.yaml# > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > index 5cb0e337ea6e..644646de338a 100644 > --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/qcom,msm8996-camss.yaml# > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > index 584106e275f6..68d8670557f5 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/qcom,sdm660-camss.yaml# > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > index d32daaef1b50..289494f561e5 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/qcom,sdm845-camss.yaml# > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml > index 06db2c1e6079..a372d991e652 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/qcom,sm8250-camss.yaml# > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > index 947ad699cc5e..d246f5d38427 100644 > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/rockchip,rk3568-vepu.yaml# > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > index 719aeb2dc593..8c2501634080 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > @@ -1,5 +1,4 @@ > # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > - > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml# > @@ -92,18 +91,18 @@ additionalProperties: false > > examples: > - | > - #include <dt-bindings/clock/rk3288-cru.h> > - #include <dt-bindings/interrupt-controller/arm-gic.h> > - #include <dt-bindings/power/rk3288-power.h> > + #include <dt-bindings/clock/rk3288-cru.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/rk3288-power.h> > > - vpu: video-codec@ff9a0000 { > - compatible = "rockchip,rk3288-vpu"; > - reg = <0xff9a0000 0x800>; > - interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "vepu", "vdpu"; > - clocks = <&cru ACLK_VCODEC>, <&cru HCLK_VCODEC>; > - clock-names = "aclk", "hclk"; > - power-domains = <&power RK3288_PD_VIDEO>; > - iommus = <&vpu_mmu>; > - }; > + video-codec@ff9a0000 { > + compatible = "rockchip,rk3288-vpu"; > + reg = <0xff9a0000 0x800>; > + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "vepu", "vdpu"; > + clocks = <&cru ACLK_VCODEC>, <&cru HCLK_VCODEC>; > + clock-names = "aclk", "hclk"; > + power-domains = <&power RK3288_PD_VIDEO>; > + iommus = <&vpu_mmu>; > + }; > -- > 2.43.0 > >