hello Dikshita, On Tue, 10 Dec 2024 at 12:08, Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> wrote: > > Initialize the platform data and enable video driver probe of SM8250 > SoC. Add a kernel param to select between venus and iris drivers for > platforms supported by both drivers, for ex: SM8250. > > Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> [...] > --- a/drivers/media/platform/qcom/iris/iris_ctrls.c > +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c > @@ -17,6 +17,8 @@ static inline bool iris_valid_cap_id(enum platform_inst_fw_cap_type cap_id) > static enum platform_inst_fw_cap_type iris_get_cap_id(u32 id) > { > switch (id) { > + case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER: > + return DEBLOCK; > case V4L2_CID_MPEG_VIDEO_H264_PROFILE: > return PROFILE; > case V4L2_CID_MPEG_VIDEO_H264_LEVEL: > @@ -32,6 +34,8 @@ static u32 iris_get_v4l2_id(enum platform_inst_fw_cap_type cap_id) > return 0; > > switch (cap_id) { > + case DEBLOCK: > + return V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER; > case PROFILE: The handling for DEBLOCK does not seem to be part of the SM8250 enablement. Or did I miss something? It seems they should be part of a different patch that makes use of the DEBLOCK cap. regards Stefan Schmidt