On Fri, Dec 06, 2024 at 01:14:26PM +0100, Konrad Dybcio wrote: > On 6.12.2024 12:04 PM, Wasim Nazir wrote: > > On Wed, Nov 20, 2024 at 05:44:11PM +0100, Krzysztof Kozlowski wrote: > >> On 19/11/2024 18:49, Wasim Nazir wrote: > >>> Add device tree support for QCS9075 Ride & Ride-r3 boards. > >>> QCS9075 Ride & Ride-r3 are similar to QCS9100 Ride and Ride-r3 > >>> boards but without safety monitoring feature of SAfety-IsLand > >>> subsystem. > >>> > >>> Difference between ride and ride-r3 is the ethernet phy. > >>> Ride uses 1G ethernet phy while ride-r3 uses 2.5G ethernet phy. > >>> > >>> Signed-off-by: Wasim Nazir <quic_wasimn@xxxxxxxxxxx> > >>> --- > >>> arch/arm64/boot/dts/qcom/Makefile | 2 ++ > >>> arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts | 12 ++++++++++++ > >>> arch/arm64/boot/dts/qcom/qcs9075-ride.dts | 12 ++++++++++++ > >>> 3 files changed, 26 insertions(+) > >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>> create mode 100644 arch/arm64/boot/dts/qcom/qcs9075-ride.dts > >>> > >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > >>> index 5d9847119f2e..91c811aca2ca 100644 > >>> --- a/arch/arm64/boot/dts/qcom/Makefile > >>> +++ b/arch/arm64/boot/dts/qcom/Makefile > >>> @@ -116,6 +116,8 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9075-rb8.dtb > >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride.dtb > >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs9075-ride-r3.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qcs9100-ride-r3.dtb > >>> dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > >>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>> new file mode 100644 > >>> index 000000000000..a04c8d1fa258 > >>> --- /dev/null > >>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-ride-r3.dts > >>> @@ -0,0 +1,12 @@ > >>> +// SPDX-License-Identifier: BSD-3-Clause > >>> +/* > >>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > >>> + */ > >>> +/dts-v1/; > >>> + > >>> +#include "sa8775p-ride-r3.dts" > >> No guys, you are making these things up. This is EXACTLY the same as > >> qcs9100. > > > > 9100 & 9075 are different from “safe” perspective. They differ in > > changes related to thermal which will be added later in devicetree. > > Since this can't be inferred from just looking at the changes, please > make sure to add that to the commit message > Sure, will add more details in next patch series. > Konrad Thanks & Regards, Wasim