On Fri, Dec 06, 2024 at 08:15:35PM +0530, Janaki Ramaiah Thota wrote: > > > On 12/5/2024 4:29 AM, Dmitry Baryshkov wrote: > > On Wed, Dec 04, 2024 at 06:47:04PM +0530, Janaki Ramaiah Thota wrote: > > > Add a node for the PMU module of the WCN6750 present on the > > > qcs6490-rb3gen board and assign its power outputs to the Bluetooth > > > module. > > > > > > Signed-off-by: Janaki Ramaiah Thota <quic_janathot@xxxxxxxxxxx> > > > --- > > > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 165 ++++++++++++++++++- > > > 1 file changed, 164 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > > index 27695bd54220..07650648214e 100644 > > > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > > @@ -1,6 +1,6 @@ > > > // SPDX-License-Identifier: BSD-3-Clause > > > /* > > > - * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > > > + * Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved. > > > */ > > > /dts-v1/; > > > @@ -33,6 +33,7 @@ > > > aliases { > > > serial0 = &uart5; > > > + serial1 = &uart7; > > > }; > > > chosen { > > > @@ -217,6 +218,63 @@ > > > regulator-min-microvolt = <3700000>; > > > regulator-max-microvolt = <3700000>; > > > }; > > > + > > > + wcn6750-pmu { > > > + compatible = "qcom,wcn6750-pmu"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&bt_en>; > > > + vddaon-supply = <&vreg_s7b_0p972>; > > > + vddasd-supply = <&vreg_l11c_2p8>; > > > + vddpmu-supply = <&vreg_s7b_0p972>; > > > + vddrfa0p8-supply = <&vreg_s7b_0p972>; > > > + vddrfa1p2-supply = <&vreg_s8b_1p272>; > > > + vddrfa1p7-supply = <&vreg_s1b_1p872>; > > > + vddrfa2p2-supply = <&vreg_s1c_2p19>; > > > + > > > + bt-enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>; > > > > Doesn't WCN6750 also have SW_CTRL and wifi-enable pins? > > > > For Bluetooth, these pins are not needed. We have verified Bluetooth > functionality, and it is working fine. You are describing the hardware (PMU), not "a part of the PMU for the BT". Please check if there should be a wifi enable pin and adjust accordingly. -- With best wishes Dmitry