Re: [PATCH net-next v8 10/15] net: macb: Use helper rgmii_clock

Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx> · Fri, 6 Dec 2024 10:47:07 +0100

On 05/12/2024 at 17:43, Jan Petrous via B4 Relay wrote:
From: "Jan Petrous (OSS)" <jan.petrous@xxxxxxxxxxx>

Utilize a new helper function rgmii_clock().

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
Signed-off-by: Jan Petrous (OSS) <jan.petrous@xxxxxxxxxxx>

If needed:
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>

Thanks, best regards,
  Nicolas

---
  drivers/net/ethernet/cadence/macb_main.c | 14 ++------------
  1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index daa416fb1724..640f500f989d 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -530,19 +530,9 @@ static void macb_set_tx_clk(struct macb *bp, int speed)
         if (bp->phy_interface == PHY_INTERFACE_MODE_MII)
                 return;

-       switch (speed) {
-       case SPEED_10:
-               rate = 2500000;
-               break;
-       case SPEED_100:
-               rate = 25000000;
-               break;
-       case SPEED_1000:
-               rate = 125000000;
-               break;
-       default:
+       rate = rgmii_clock(speed);
+       if (rate < 0)
                 return;
-       }

         rate_rounded = clk_round_rate(bp->tx_clk, rate);
         if (rate_rounded < 0)

--
2.47.0










