Re: [PATCH RFC 1/2] dt-bindings: mailbox: qcom: Document qcom,tmelite-qmp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/5/2024 5:54 PM, Dmitry Baryshkov wrote:
On Thu, Dec 05, 2024 at 01:36:32PM +0530, Sricharan R wrote:
From: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>

This binding describes the component responsible for communication
between the TME-L server based subsystems (Q6) and the TME-L client

This should start by explaining what is TME-L.

ok, will change.

(APPSS/BTSS/AUDIOSS), used for security services like secure image
authentication, enable/disable efuses, crypto services. Each client
in the   SoC has its own block of message RAM and IRQ for communication
with the TME-L SS. The protocol used to communicate in the message RAM
is known as Qualcomm Messaging Protocol (QMP).

Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
---
  .../bindings/mailbox/qcom,tmelite-qmp.yaml    | 70 +++++++++++++++++++
  1 file changed, 70 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/mailbox/qcom,tmelite-qmp.yaml

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,tmelite-qmp.yaml b/Documentation/devicetree/bindings/mailbox/qcom,tmelite-qmp.yaml
new file mode 100644
index 000000000000..1f2b3e02b894
--- /dev/null
+++ b/Documentation/devicetree/bindings/mailbox/qcom,tmelite-qmp.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mailbox/qcom,tmelite-qmp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm TMELITE IPCC channel

So, TME-L or TMELITE or TME-LITE?

ok, will use TME-L in all places.

+
+maintainers:
+  - Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
+
+description:
+  This binding describes the component responsible for communication

It's already a description of the binding, no need to repeat the obvious.

ok

+  between the TME-L server based subsystems (Q6) and the TME-L client
+  (APPSS/BTSS/AUDIOSS), used for security services like secure image
+  authentication, enable/disable efuses, crypto services. Each client
+  in the   SoC has its own block of message RAM and IRQ for communication
+  with the TME-L SS. The protocol used to communicate in the message RAM
+  is known as Qualcomm Messaging Protocol (QMP).
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - qcom,ipq5424-tmelite-qmp
+      - const: qcom,tmelite-qmp
+
+  reg:
+    maxItems: 1
+    description:
+      The base address and size of the message RAM for this client's
+      communication with the TMELITE core
+
+  interrupts:
+    maxItems: 1
+    description:
+      Should specify the TMELITE message IRQ for this client

Just should? This is a very relaxed constraint. Just "the message IRQ
for the client" sounds better.

ok, will reword.


Regards,
 Sricharan





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux