On 3.12.2024 7:03 AM, Yu Zhang(Yuriy) wrote:
> Add a node for the PMU module of the WCN6855 present on the qcs615
> board. Assign its LDO power outputs to the existing WiFi/BT module.
>
subject:
arm64: dts: qcom: qcs615-ride: ....
[...]
> +
> + vreg_conn_1p8: vreg_conn_1p8 {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_conn_1p8";
> + startup-delay-us = <4000>;
> + enable-active-high;
> + gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
> + };
> +
> + vreg_conn_pa: vreg_conn_pa {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_conn_pa";
> + startup-delay-us = <4000>;
> + enable-active-high;
> + gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
> + };
Are any of these boot-on?
> +
> + wcn6855-pmu {
> + compatible = "qcom,wcn6855-pmu";
> +
> + pinctrl-0 = <&bt_en_state>, <&wlan_en_state>;
> + pinctrl-names = "default";
> +
> + vddio-supply = <&vreg_conn_pa>;
> + vddaon-supply = <&vreg_s5a>;
> + vddpmu-supply = <&vreg_conn_1p8>;
> + vddrfa0p95-supply = <&vreg_s5a>;
> + vddrfa1p3-supply = <&vreg_s6a>;
> + vddrfa1p9-supply = <&vreg_l15a>;
> + vddpcie1p3-supply = <&vreg_s6a>;
> + vddpcie1p9-supply = <&vreg_l15a>;
> +
> + bt-enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
> + wlan-enable-gpios = <&tlmm 98 GPIO_ACTIVE_HIGH>;
Please move these properties above supplies, to match the style in
other recent device trees
[...]
> &rpmhcc {
> clocks = <&xo_board_clk>;
> };
> @@ -262,12 +363,42 @@ wake-pins {
> bias-pull-up;
> };
> };
> +
> + wlan_en_state: wlan-en-state {
> + pins = "gpio98";
> + function = "gpio";
> + drive-strength = <16>;
> + output-high;
> + bias-pull-up;
> + };
> +
> + bt_en_state: bt-en-state {
> + pins = "gpio85";
> + function = "gpio";
> + output-low;
> + bias-pull-down;
> + };
These should be sorted by gpio idx
Konrad
