On Wed, Dec 04, 2024 at 10:43:56PM +0800, Lei Wei wrote: > +static int ipq_pcs_link_up_config_usxgmii(struct ipq_pcs *qpcs, int speed) > +{ ... > + /* USXGMII only support full duplex mode */ > + val |= XPCS_DUPLEX_FULL; Again... this restriction needs to be implemented in .pcs_validate() by knocking out the half-duplex link modes when using USXGMII mode. .pcs_validate() needs to be implemented whenever the PCS has restrictions beyond what is standard for the PHY interface mode. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!