пн, 4 нояб. 2024 г. в 17:15, Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>: > > On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote: > > Add support for s2dos05 display / touchscreen PMIC > > > > Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx> > > --- > > Changes in v6: > > - refactor: s/starqltechn/sdm845-starqltechn in subject > > - refactor: 'i' < 'm', so put tlmm i2c node before motor* > > Now you have 'i'2c21 before 'g'pio-regulator :/ That refactor was about tlmm inner nodes. For soc nodes rule `nodes of the same type can be grouped together` should apply I guess. I think I should move it to regulators. > [...] > > > > > + i2c21 { > > + compatible = "i2c-gpio"; > > I'm not sure this has been asked before - is the GENI SE for I2C21 > disabled? Or are there reasons to use i2c-gpio instead? > I2c21 is wired on pins 127, 128, and those pins don't have a GENI SE function. -- Best regards and thanks for review, Dzmitry