[ Forgot to CC the regressions list ] On Sun, Dec 01, 2024 at 06:11:20PM +0100, Johan Hovold wrote: > A recent change converting the MHI pci_generic driver to use > pcim_iomap_region() failed to update the BAR parameter which is an index > rather than a mask. > > This specifically broke the modem on machines like the Lenovo ThinkPad > X13s and x1e80100 CRD: > > mhi-pci-generic 0004:01:00.0: failed to map pci region: -22 > mhi-pci-generic 0004:01:00.0: probe with driver mhi-pci-generic failed with error -22 > > Fixes: bd23e836423e ("bus: mhi: host: pci_generic: Use pcim_iomap_region() to request and map MHI BAR") > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > Cc: Mayank Rana <quic_mrana@xxxxxxxxxxx> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > --- > > The offending patch was marked as "Compile tested only", but that just > makes you wonder *why* the patch was never tested... > > https://lore.kernel.org/all/20241004023351.6946-1-manivannan.sadhasivam@xxxxxxxxxx/ #regzbot ^introduced: bd23e836423e Johan