Hi Dmitry, On 11/30/2024 1:13 AM, Dmitry Baryshkov wrote: > On Fri, Nov 29, 2024 at 10:30:00AM +0800, Cheng Jiang (IOE) wrote: >> Hi Dmitry, >> >> On 11/28/2024 8:58 PM, Dmitry Baryshkov wrote: >>> On Thu, Nov 28, 2024 at 08:09:21PM +0800, Cheng Jiang wrote: >>>> Add the compatible for the Bluetooth part of the Qualcomm QCA6698 chipset. >>> >>> ... >>> And you have misssed to explain why do you need to add it and how it is >>> different from WCN6855. >>> >> Got it. I just explain in the dts/driver change, forget to explain here. >> >> If use the firmware-name solution, do we still need add the new compatible >> string for qcom,qca6698-bt here? The driver may not use this string. > > DT describes the hardware. If you want, you can still add new string > _and_ use old one as a fallback compatible: "qcom,qca6698-bt", > "qcom,wcn6855-bt". Got it. Thanks! > >>>> >>>> Signed-off-by: Cheng Jiang <quic_chejiang@xxxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>> index 7bb68311c..82105382a 100644 >>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>> @@ -18,6 +18,7 @@ properties: >>>> enum: >>>> - qcom,qca2066-bt >>>> - qcom,qca6174-bt >>>> + - qcom,qca6698-bt >>>> - qcom,qca9377-bt >>>> - qcom,wcn3988-bt >>>> - qcom,wcn3990-bt >>>> @@ -170,6 +171,7 @@ allOf: >>>> contains: >>>> enum: >>>> - qcom,wcn6855-bt >>>> + - qcom,qca6698-bt >>>> then: >>>> required: >>>> - vddrfacmn-supply >>>> -- >>>> 2.25.1 >>>> >>> >> >
