SC8280XP, SA8540P and SA8295P have main XO clock definition split between the SoC dtsi file and the board file. This is not optimal, as the clocks are a part of the SoC + PMICs design. Frequencies are common for the whole set of devices using the same SoC. Remove the split and move frequencies to the SoC DTSI file. Suggested-by: Bjorn Andersson <andersson@xxxxxxxxxx> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> --- arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 4 ---- arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 4 ---- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 4 ---- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ---- arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts | 4 ---- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + 6 files changed, 1 insertion(+), 20 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts index 2fd1dafe63ce7a4f409d19946b9f10ffe324fba3..c536df2acc66276a0bf4e3b2640ee204109867f7 100644 --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts @@ -728,10 +728,6 @@ &usb_2_qmpphy1 { status = "okay"; }; -&xo_board_clk { - clock-frequency = <38400000>; -}; - /* PINCTRL */ &pmm8540a_gpios { diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts index 177b9dad6ff703467ea4d10e0f5a651d11569275..64c35a72a828c128f9dbe9e3537a3f777d21713b 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts @@ -503,10 +503,6 @@ &usb_2_qmpphy0 { status = "okay"; }; -&xo_board_clk { - clock-frequency = <38400000>; -}; - /* PINCTRL */ &tlmm { diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts index 75adaa19d1c3e0c8fcad40c7d0b0afb504331d75..61ae4d0a9e7d10387a8331fbc22d5f88edaa9c23 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -868,10 +868,6 @@ &usb_1_qmpphy_out { remote-endpoint = <&pmic_glink_con1_ss>; }; -&xo_board_clk { - clock-frequency = <38400000>; -}; - /* PINCTRL - additions to nodes defined in sc8280xp.dtsi */ &pmc8280_1_gpios { diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index f3190f408f4b2c7ca9fe368d652d5d66bb3949af..bee1e143178be5971a5916c368a5e8c864927b47 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -1481,10 +1481,6 @@ &wsamacro { status = "okay"; }; -&xo_board_clk { - clock-frequency = <38400000>; -}; - /* PINCTRL */ &lpass_tlmm { diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts index ae5daeac8fe284bbec86622c10e6831d60a25297..c4a19ecbd894cbdd0521bbf784efd23f46eb07f0 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts @@ -837,10 +837,6 @@ &wsamacro { status = "okay"; }; -&xo_board_clk { - clock-frequency = <38400000>; -}; - /* PINCTRL */ &lpass_tlmm { diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index ef06d1ac084d3205a149feff880f457822dca2b4..e6517ad9408d9a49da9c00bcb661f32539fa32e6 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -31,6 +31,7 @@ clocks { xo_board_clk: xo-board-clk { compatible = "fixed-clock"; #clock-cells = <0>; + clock-frequency = <38400000>; }; sleep_clk: sleep-clk { -- 2.39.5