Re: [PATCH v5 2/3] clk: qcom: common: Add support for power-domain attachment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bryan,

On 11/28/24 18:38, Bryan O'Donoghue wrote:
Right now we support one power-domain per clock controller.
These single power-domains are switched on by the driver platform logic.

However when we have multiple power-domains attached to a clock-controller
that list of power-domains must be handled outside of driver platform
logic.

Use devm_pm_domain_attach_list() to automatically hook the list of given
power-domains in the dtsi for the clock-controller driver.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
---
  drivers/clk/qcom/common.c | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
index 33cc1f73c69d1f875a193aea0552902268dc8716..e6a024e95ab5f4b0776ffc6c7b3bebfbebb007fd 100644
--- a/drivers/clk/qcom/common.c
+++ b/drivers/clk/qcom/common.c
@@ -22,6 +22,7 @@ struct qcom_cc {
  	struct qcom_reset_controller reset;
  	struct clk_regmap **rclks;
  	size_t num_rclks;
+	struct dev_pm_domain_list *pd_list;
  };
const
@@ -294,11 +295,19 @@ int qcom_cc_really_probe(struct device *dev,
  	struct clk_regmap **rclks = desc->clks;
  	size_t num_clk_hws = desc->num_clk_hws;
  	struct clk_hw **clk_hws = desc->clk_hws;
+	struct dev_pm_domain_attach_data pd_data = {
+		.pd_names = 0,
+		.num_pd_names = 0,
+	};
cc = devm_kzalloc(dev, sizeof(*cc), GFP_KERNEL);
  	if (!cc)
  		return -ENOMEM;
+ ret = devm_pm_domain_attach_list(dev, &pd_data, &cc->pd_list);

Please make a call to the function like this:

	ret = devm_pm_domain_attach_list(dev, NULL, &cc->pd_list);

Here pd_data is unused.

+	if (ret < 0 && ret != -EEXIST)
+		return ret;
+
  	reset = &cc->reset;
  	reset->rcdev.of_node = dev->of_node;
  	reset->rcdev.ops = &qcom_reset_ops;


--
Best wishes,
Vladimir




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux