On 28/11/2024 17:49, Andrew Lunn wrote: > On Thu, Nov 28, 2024 at 04:44:46PM +0800, Jingyi Wang wrote: >> Add initial support for Qualcomm QCS8300 RIDE board which enables DSPs, >> UFS and booting to shell with uart console. >> >> Written with help from Tingguo Cheng (added rpmhpd nodes) and Xin Liu >> (added ufs, adsp and gpdsp nodes). >> >> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> >> Signed-off-by: Jingyi Wang <quic_jingyw@xxxxxxxxxxx> >> --- >> arch/arm64/boot/dts/qcom/Makefile | 2 +- >> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 267 ++++++++++++++++++++++++++++++ >> 2 files changed, 268 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 9bb8b191aeb5..d9545743606a 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -114,7 +114,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcm6490-shift-otter.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb >> -dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += qcs8300-ride.dtb > > It would be good to add a comment to the commit message about why you > are removing qcs8550-aim300-aiot.dtb from the Makefile. Especially that it was not in v2 (which I reviewed) and nothing in the changelog explains this removal. Best regards, Krzysztof
