On Tue, Jun 28, 2016 at 02:43:02PM -0700, Thomas Pedersen wrote: > From: Andy Gross <andy.gross@xxxxxxxxxx> > > This patch removes the crci information from the dma > channel property. At least one client device requires > using more than one CRCI value for a channel. This does > not match the current binding and the crci information > needs to be removed. > > Instead, the client device will provide this information > via other means. > > Signed-off-by: Andy Gross <andy.gross@xxxxxxxxxx> > Signed-off-by: Thomas Pedersen <twp@xxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/dma/qcom_adm.txt | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom_adm.txt b/Documentation/devicetree/bindings/dma/qcom_adm.txt > index 9bcab91..38d45f8 100644 > --- a/Documentation/devicetree/bindings/dma/qcom_adm.txt > +++ b/Documentation/devicetree/bindings/dma/qcom_adm.txt > @@ -4,8 +4,7 @@ Required properties: > - compatible: must contain "qcom,adm" for IPQ/APQ8064 and MSM8960 > - reg: Address range for DMA registers > - interrupts: Should contain one interrupt shared by all channels > -- #dma-cells: must be <2>. First cell denotes the channel number. Second cell > - denotes CRCI (client rate control interface) flow control assignment. > +- #dma-cells: must be <1>. First cell denotes the channel number. I've actually been thinking more about this. The crci being specified in the slave config is probably the wrong approach. What we really need is each physical DMA channel to allow for virtual channels that allow for a CRCI setting (0 being no flow control). This would require the properties to continue to be 2 for the dma definition. This would also require clients to get multiple references to the same DMA channel if they require some communications with and without flow control. For NAND, this would mean having two channels for dma. One for flow controlled and one without. Anyone have reservations with this? Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
