On 11/15/2024 2:59 PM, Dmitry Baryshkov wrote:
SM8450 is one of the platforms where board-level clocks (XO, sleep) are
fully defined in the SoC dtsi file. This is not correct and doesn't
fully follow the DT guidelines. Move these two clocks to the board files
completely.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 14 ++++++++++++++
arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 14 ++++++++++++++
arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/qcom/sm8450.dtsi | 14 --------------
4 files changed, 42 insertions(+), 14 deletions(-)
<...>
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 53147aa6f7e4acb102dd5dee51f0aec164b971c7..7dc183cc5c29374a19aabb36086e27edfffeaf37 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -33,20 +33,6 @@ / {
chosen { };
- clocks {
- xo_board: xo-board {
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <76800000>;
- };
-
- sleep_clk: sleep-clk {
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <32000>;
- };
- };
-
Sleep clock is moved to board device tree while reference of this clock
is still in soc device tree like gcc node. Is this preferrable way to
reference the node defined in board device in soc device tree?
cpus {
#address-cells = <2>;
#size-cells = <0>;
--
Thanks,
Tingwei
