On 10/16/2024 2:30 PM, Krzysztof Kozlowski wrote: >>>> + description: >>>> + phandle to a node describing reserved memory (System RAM memory) >>>> + used by ath12k firmware (see bindings/reserved-memory/reserved-memory.txt) >>>> + >>>> + qcom,rproc: >>>> + $ref: /schemas/types.yaml#/definitions/phandle >>>> + description: >>>> + DT entry of a WCSS node. WCSS node is the child node of q6 remoteproc driver. >>>> + (see bindings/remoteproc/qcom,multipd-pil.yaml) >>> DT nodes are not children of drivers. But other DT nodes. Explain why >>> this phandle is needed, what is it for. >>> >>> To me it looks like you incorrectly organized your nodes. >>> >> This phandle is required by wifi driver (ath12k) to retrieve the correct remote processor >> (rproc_get_by_phandle()). Ath12k driver needs this rproc to interact with the remote >> processor (example: booting-up remote processor). > That's driver aspect. Why does the hardware needs it? > > WiFi is the remote processor, so I would expect this being a child. Or > just drop entirely. > > You keep using here arguments how you designed your drivers, which is > not valid. Sorry, fix your drivers... or use arguments in terms of hardware. > > >> In next version, will correct the description based on existing bindings (qcom,ath11k.yaml). > Sorry, let's don't copy existing solutions just because they exist. In the IPQ5332 platform, the WiFi component, known as the Wireless Control Subsystem (WCSS), functions as the wireless controller. Additionally, there is a separate hardware module, the Qualcomm Hexagon DSP(q6 remote processor), which is utilized for offloading WiFi processing tasks. These two hardware modules operate in conjunction, necessitating a phandle in the WiFi node that references the remote processor. Despite their interdependence, these modules are distinct from a hardware perspective.
