Re: [PATCH 3/6] drm/msm/dpu: Add QCS615 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 22 Nov 2024 at 09:36, fange zhang <quic_fangez@xxxxxxxxxxx> wrote:
>
>
>
> On 2024/11/18 18:55, Dmitry Baryshkov wrote:
> > On Mon, 18 Nov 2024 at 10:52, fange zhang <quic_fangez@xxxxxxxxxxx> wrote:
> >>
> >>
> >>
> >> On 2024/10/14 18:47, Dmitry Baryshkov wrote:
> >>> On Mon, Oct 14, 2024 at 05:47:29PM +0800, fangez via B4 Relay wrote:
> >>>> From: lliu6 <quic_lliu6@xxxxxxxxxxx>
> >>>>
> >>>> Add support for the display hardware used on the Qualcomm QCS615 platform.
> >>>
> >>> Not all hardware is described here, comment regarding the DP, etc.
> Fixed in v2
> for DPU part, commit message would be:
>
> Author: Li Liu <quic_lliu6@xxxxxxxxxxx>
> Date:   Tue Oct 15 12:50:26 2024 +0800
>
>      drm/msm/dpu: Add SM6150 support
>
>      Add definitions for the display hardware
>      used on the Qualcomm SM6150 platform.

Please wrap the lines in the commit message according to the
established recommendations rather than doing it at some other point.

>
>      Signed-off-by: Li Liu <quic_lliu6@xxxxxxxxxxx>
>      Signed-off-by: Fange Zhang <quic_fangez@xxxxxxxxxxx>
>
> with these file changes:
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_3_sm6150.h
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
>
> >>>
> >>>>
> >>>> Signed-off-by: lliu6 <quic_lliu6@xxxxxxxxxxx>
> >>>> ---
> >>>>    .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_3_qcs615.h | 268 +++++++++++++++++++++
> >>>>    drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c     |   1 +
> >>>>    drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h     |   1 +
> >>>>    drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |   1 +
> >>>
> >>>>    drivers/gpu/drm/msm/dsi/dsi_cfg.c                  |  17 ++
> >>>>    drivers/gpu/drm/msm/dsi/dsi_cfg.h                  |   1 +
> >>>
> >>> These changes are not related to the DPU, which you listed as a prefix
> >>> in the commit message
> >> ok will split it to these four parts.
> >> 1. dpu hw catalog
> >> 2. mdss
> >> 3. dsi phy
> >> 4. dsi
> >> sorry, one more question about it.
> >> is the driver patch order correct?
> >
> > Usually MDSS comes before DPU
> Got it, will fix in next patch.
> New driver patch order as follows:
> drm/msm: mdss: Add SM6150 support
> drm/msm/dpu: Add SM6150 support
> drm/msm/dsi: Add support for SM6150
> drm/msm/dsi: Add dsi phy support for SM6150
>
> >
> >>>
> >>>>    drivers/gpu/drm/msm/dsi/phy/dsi_phy.c              |   2 +
> >>>>    drivers/gpu/drm/msm/dsi/phy/dsi_phy.h              |   1 +
> >>>>    drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c         |  21 ++
> >>>
> >>> These changes are not related to the DPU
> >>>
> >>>>    drivers/gpu/drm/msm/msm_mdss.c                     |   7 +
> >>>
> >>> These changes are not related to the DPU
> >>>
> >>> For the whole patch: s/qcs615/sm6150/g
> >>>
> >>>>    10 files changed, 320 insertions(+)
> >>>>
> >
> >
>


-- 
With best wishes
Dmitry




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux