On Thu, Nov 21, 2024 at 10:49 AM Rob Clark <robdclark@xxxxxxxxx> wrote: > > On Wed, Nov 20, 2024 at 5:17 PM Petr Vorel <pvorel@xxxxxxx> wrote: > > > > > On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel <pvorel@xxxxxxx> wrote: > > > > > > It will be used in the next commit for DRM_MSM. > > > > > > Suggested-by: Rob Clark <robdclark@xxxxxxxxx> > > > > Signed-off-by: Petr Vorel <pvorel@xxxxxxx> > > > > --- > > > > Changes v3->v4: > > > > * Move definition to the end of the file > > > > > > > I prefer to not check the tool. > > > > Ack. > > > > > Why don't you install python3? > > > > Everybody installs it when it's required, the question is how to inform about > > the dependency. > > > > There build environments are minimal environments: > > * chroot (e.g. cross compilation) > > * container > > > > These are used by both developers and distros. > > I don't think py3 is an _onerous_ dependency, but it has come up as a > surprise in minimal distro build environments at least once.. so I'd > be a fan of surfacing this dependency in a predictable/understandable > way (ie. I'm in favor of this patchset) "once" is a keyword here. "/bin/sh: python3: not found" provides sufficient information about why the compilation failed, and you know what to do to fix the problem. This is good. If you hide CONFIG_DRM_MSM silently due to missing python3, you may scratch your head "why drm/msm was not compiled?". This is worse. -- Best Regards Masahiro Yamada
