On Wed, 20 Nov 2024 at 22:48, Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx> wrote: > > On 11/20/2024 1:36 PM, Sergey Ryazanov wrote: > > +Manivannan > > > > Hello Jerry, > > > > this version looks a way better, still there is one minor thing to > > improve. See below. > > > > Manivannan, Loic, could you advice is it Ok to export that SAHARA port > > as is? > > I'm against this. > > There is an in-kernel Sahara implementation, which is going to be used > by QDU100. If WWAN is going to own the "SAHARA" MHI channel name, then > no one else can use it which will conflict with QDU100. > > I expect the in-kernel implementation can be leveraged for this. Fair enough, actually the same change has already been discussed two years ago, and we agreed that it should not be exposed as a WWAN control port: https://lore.kernel.org/netdev/CAMZdPi_7KGx69s5tFumkswVXiQSdxXZjDXT5f9njRnBNz1k-VA@xxxxxxxxxxxxxx/#t Regards, Loic