On Tue, Nov 19, 2024 at 11:38:34AM +0530, Taniya Das wrote:
>
>
> On 11/18/2024 7:54 AM, Bryan O'Donoghue wrote:
> > On x1e80100 and it's SKUs the Camera Clock Controller - CAMCC has
> > multiple power-domains which power it. Usually with a single power-domain
> > the core platform code will automatically switch on the singleton
> > power-domain for you. If you have multiple power-domains for a device, in
> > this case the clock controller, you need to switch those power-domains
> > on/off yourself.
> >
> > The clock controllers can also contain Global Distributed
> > Switch Controllers - GDSCs which themselves can be referenced from dtsi
> > nodes ultimately triggering a gdsc_en() in drivers/clk/qcom/gdsc.c.
> >
> > As an example:
> >
> > cci0: cci@ac4a000 {
> > power-domains = <&camcc TITAN_TOP_GDSC>;
> > };
> >
> > This series adds the support to attach a power-domain list to the
> > clock-controllers and the GDSCs those controllers provide so that in the
> > case of the above example gdsc_toggle_logic() will trigger the power-domain
> > list with pm_runtime_resume_and_get() and pm_runtime_put_sync()
> > respectively.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > ---
>
> Bryan, as we were already in discussion with Bjorn to post the patches which
> take care of Multi GDSC and PLL requirements, I would request to kindly hold
> this series posting.
There's no "hold before posting", this series is already posted.
Please review it.
> I am in the final discussions with Bjorn to handle it
> gracefully to post the series.
>
You may in such discussion (the review) say "you're missing X, Y, Z, and
here is my patches that covers these aspects", but not "I'll ignore this
until we're done preparing our patches".
Regards,
Bjorn
