On 2024/10/14 18:30, Dmitry Baryshkov wrote:
On Mon, Oct 14, 2024 at 05:47:30PM +0800, fangez via B4 Relay wrote:
From: lliu6 <quic_lliu6@xxxxxxxxxxx>
QCS615 platform uses the 14nm DSI PHY driver.
- bindings describe the hardware, not the drivers.
- other platforms also have 14nm DSI PHY. Why do you need a separate
compatible?
We need to introduce a new regulator configuration for the PHY:
dsi_phy_14nm_36mA_regulators. This configuration has not been used before.
Signed-off-by: lliu6 <quic_lliu6@xxxxxxxxxxx>
---
Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
index 52bbe132e6dae57246200757767edcd1c8ec2d77..029606d9e87e3b184bd10bd4a5076d6923d60e9e 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
@@ -20,6 +20,7 @@ properties:
- qcom,dsi-phy-14nm-660
- qcom,dsi-phy-14nm-8953
- qcom,sm6125-dsi-phy-14nm
+ - qcom,qcs615-dsi-phy-14nm
sorry, still have some question about this yaml file.
it's necessary for b4 check
checkpatch.pl: drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:564: WARNING: DT
compatible string "qcom,dsi-phy-14nm-6150" appears un-doc
umented -- check ./Documentation/devicetree/bindings/
need to add this new 6150 node for dsi-phy-14nm.
shall i add it?
reg:
items:
--
2.25.1
and could you please help to review the new version?
Author: Li Liu <quic_lliu6@xxxxxxxxxxx>
Date: Tue Nov 19 12:35:12 2024 +0800
dt-bindings: display/msm: Add SM6150 DSI phy
Add new compatible for SM6150 with dsi_phy_14nm_36mA_regulators
Signed-off-by: Li Liu <quic_lliu6@xxxxxxxxxxx>
Signed-off-by: Fange Zhang <quic_fangez@xxxxxxxxxxx>
diff --git
a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
index 52bbe132e6da..fd6eb3434450 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
@@ -17,6 +17,7 @@ properties:
enum:
- qcom,dsi-phy-14nm
- qcom,dsi-phy-14nm-2290
+ - qcom,dsi-phy-14nm-6150
- qcom,dsi-phy-14nm-660
- qcom,dsi-phy-14nm-8953
- qcom,sm6125-dsi-phy-14nm
