On Tue, Nov 12, 2024 at 06:08:10PM -0800, Sagar Cheluvegowda wrote: > All Qualcomm platforms have only supported EMAC version 4 until > now whereas in future we will also be supporting XGMAC version > which has higher capabilities than its peer. As both has_gmac4 > and has_xgmac fields cannot co-exist, make sure to disable the > former flag when has_xgmac is enabled. If you say they are mutually exclusive, how can it happen that both are enabled? To me, this feels like you are papering over a bug somewhere else. Andrew