On 11/12/2024 4:34 PM, Konrad Dybcio wrote:
On 11/5/24 17:49, Krishna Kurapati wrote:
Add support for USB controllers on QCS8300. The second
controller is only High Speed capable.
Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
---
[...]
(the PHYs look good)
+ usb_1: usb@a6f8800 {
+ compatible = "qcom,qcs8300-dwc3", "qcom,dwc3";
+ reg = <0x0 0x0a6f8800 0x0 0x400>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
Please match the property style with x1e80100.dtsi's dwc3 node
Meaning adding the 3 properties to before the starting of dwc3 node ?
[...]
+
+ usb_2_dwc3: usb@a400000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0x0a400000 0x0 0xe000>;
+ interrupts = <GIC_SPI 442 IRQ_TYPE_LEVEL_HIGH>;
+ iommus = <&apps_smmu 0x20 0x0>;
+ phys = <&usb_2_hsphy>;
+ phy-names = "usb2-phy";
+ snps,dis-u1-entry-quirk;
+ snps,dis-u2-entry-quirk;
+ snps,dis_u2_susphy_quirk;
+ snps,dis_u3_susphy_quirk;
+ snps,dis_enblslpm_quirk;
maximum-speed = "high-speed"
Ideally this is not needed for the driver to operate. Can I add this
property when I send the patch to enable second controller on ride
platform ? Only reason I ask is this is not a blocker and it would need
another rebase.
Regards,
Krishna,
