On 4.11.2024 8:38 AM, Varadarajan Narayanan wrote:
> The 'broadcast' register space is present only in chipsets that
> have multiple instances of LLCC IP. Since IPQ5424 has only one
> instance, both the LLCC and LLCC_BROADCAST points to the same
> register space.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
[...]
> +static const struct llcc_slice_config ipq5424_data[] = {
> + {
> + .usecase_id = LLCC_CPUSS,
> + .slice_id = 1,
> + .max_cap = 768,
> + .priority = 1,
> + .bonus_ways = 0xFFFF,
> + .retain_on_pc = 1,
> + .activate_on_init = 1,
> + .write_scid_cacheable_en = 1,
> + .stale_en = 1,
> + .stale_cap_en = 1,
> + .alloc_oneway_en = 1,
> + .ovcap_en = 1,
> + .ovcap_prio = 1,
> + .vict_prio = 1,
Many of these are booleans, please use true/false values
[...]
>
> - drv_data->bcast_regmap = qcom_llcc_init_mmio(pdev, i, "llcc_broadcast_base");
> - if (IS_ERR(drv_data->bcast_regmap)) {
> - ret = PTR_ERR(drv_data->bcast_regmap);
> - goto err;
> + if (num_banks == 1) {
> + drv_data->bcast_regmap = regmap;
> + } else {
> + drv_data->bcast_regmap = qcom_llcc_init_mmio(pdev, i, "llcc_broadcast_base");
> + if (IS_ERR(drv_data->bcast_regmap)) {
> + ret = PTR_ERR(drv_data->bcast_regmap);
> + goto err;
> + }
> }
This won't work. See for example
https://lore.kernel.org/linux-arm-msm/20241031-add_llcc_dts_node_for_qcs615-v2-1-205766a607ca@xxxxxxxxxxx/
Which has both just one bank and llcc_broadcase_base.
You probably want to introduce a quirk like:
if (IS_ERR(drv_data->bcast_regmap)) {
if (cfg->no_broadcast_register)
bcast_regmap = drv_data->regmaps[0];
else {
ret = PTR_ERR(drv_data->bcast_regmap);
goto err;
}
}
Konrad
