On 29.10.2024 8:52 AM, Johan Hovold wrote:
> Add the missing HID supplies to avoid relying on other consumers to keep
> them on.
>
> This also avoids the following warnings on boot:
>
> i2c_hid_of 0-0010: supply vdd not found, using dummy regulator
> i2c_hid_of 0-0010: supply vddl not found, using dummy regulator
> i2c_hid_of 1-0015: supply vdd not found, using dummy regulator
> i2c_hid_of 1-0015: supply vddl not found, using dummy regulator
> i2c_hid_of 1-003a: supply vdd not found, using dummy regulator
> i2c_hid_of 1-003a: supply vddl not found, using dummy regulator
>
> Note that VREG_MISC_3P3 is also used for things like the fingerprint
> reader which are not yet fully described so mark the regulator as always
> on for now.
>
> Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
> Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> ---
[...]
>
> + vreg_misc_3p3: regulator-misc-3p3 {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "VREG_MISC_3P3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&pm8550ve_8_gpios 6 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&misc_3p3_reg_en>;
property-n
property-names
for consistency, please
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad
