On Tue, Oct 29, 2024 at 05:22:46PM -0400, Richard Acayan wrote: > On Mon, Jul 29, 2024 at 09:38:21PM -0400, Richard Acayan wrote: > > This adds the SMMU v2 for the Snapdragon 670, used for the Adreno GPU. > > > > Richard Acayan (2): > > dt-bindings: iommu: arm,smmu: add sdm670 adreno iommu compatible > > iommu/arm-smmu-qcom: add sdm670 adreno iommu compatible > > > > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + > > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + > > 2 files changed, 2 insertions(+) > > Hi, I'm wondering if this is still being considered. > > The NAK doesn't really make sense here, as there's a warning/BUG at the > bottom of the qcom SMMU driver that occurs when the compatible isn't > added: Please resend it, adding an explicit note about having no generic -v2 fallback and that being a correct way. I don't think Krzysztof reacts to old patches. > > /* > * If you hit this WARN_ON() you are missing an entry in the > * qcom_smmu_impl_of_match[] table, and GPU per-process page- > * tables will be broken. > */ > WARN(of_device_is_compatible(np, "qcom,adreno-smmu"), > "Missing qcom_smmu_impl_of_match entry for: %s", > dev_name(smmu->dev)); > > DTS change for context (pending): > https://lore.kernel.org/linux-arm-msm/20240806214452.16406-10-mailingradian@xxxxxxxxx -- With best wishes Dmitry
